search

EightfoldAI / octuple

The Octuple component library
MIT License
16 stars 45 forks source link

[TwoStateButton] ButtonShape.Round not working with TwoStateButton #784

Closed rkondra-eightfold closed 4 months ago

rkondra-eightfold commented 4 months ago

This line of code is missing in TwoStateButton https://github.com/EightfoldAI/octuple/blob/f796ff97ee5e40b39a20f670832b63f7c36fe0a8/src/components/Button/Button.tsx#L161

Screenshot 2024-02-13 at 9 47 23 AM
dkilgore-eightfold commented 4 months ago

TwoStateButton should never be used as an icon button.

dkilgore-eightfold commented 4 months ago

You may be considering ButtonShape.Pill?

dkilgore-eightfold commented 4 months ago

If it's not the shape, use a plain old Neutral toggle button.

rkondra-eightfold commented 4 months ago

Hi @dkilgore-eightfold - for now using Pill shape with a border radius (from styles.round), but only TwoStateButton has the color change inbuilt, can you please point me to some example where we are doing this with Neutral toggle button (I think involves different classes to manipulate color?)

rkondra-eightfold commented 4 months ago

https://github.com/EightfoldAI/vscode/pull/54593#discussion_r1487150173