fix: a11y: numerous screen reader fixes

dkilgore-eightfold commented 7 months ago

SUMMARY:

Adds default aria-describedby to Tooltip, with annotation for how to make accessible content that is not string
Updates List to include home and end key support, adding this functionality to Select, Menu, and Dropdown that contain a List
Improves Select screen reader support to read the number of options and which one is currently selected
Removes redundant aria-checked from Button, SplitButton, and TwoStateButton, deferring to its already-existing aria-pressed attribute instead
deprecates List disableArrowKeys in favor of disableKeys now that end and home are supported
Adds UT
Updates role properties in story implementations to better demonstrate Menu and Dropdown

https://github.com/EightfoldAI/octuple/assets/99700808/bd594772-b0de-402e-8387-33a71221fd8a

JIRA TASK (Eightfold Employees Only):

ENG-78664

CHANGE TYPE:

[x] Bugfix Pull Request
[ ] Feature Pull Request

TEST COVERAGE:

[ ] Tests for this change already exist
[x] I have added unittests for this change

TEST PLAN:

Pull the PR branch and run yarn and yarn storybook. Verify keyboard and screen reader changes in Dropdown, Menu, and Select stories. Verify List story behaves as it did previously.

codesandbox-ci[bot] commented 7 months ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

codecov[bot] commented 7 months ago

Codecov Report

Attention: Patch coverage is 89.28571% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 84.36%. Comparing base (c9d0e83) to head (c1500f2).

Files	Patch %	Lines
src/components/Tooltip/Tooltip.tsx	33.33%	1 Missing and 1 partial :warning:
src/components/List/List.tsx	95.45%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #789 +/- ## ========================================== - Coverage 84.37% 84.36% -0.01% ========================================== Files 1008 1008 Lines 19866 19890 +24 Branches 7530 7540 +10 ========================================== + Hits 16761 16781 +20 - Misses 3023 3026 +3 - Partials 82 83 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

EightfoldAI / octuple