EightfoldAI / octuple

The Octuple component library
MIT License
16 stars 45 forks source link

feat: drawer: add drawer component #795

Closed dkilgore-eightfold closed 2 months ago

dkilgore-eightfold commented 3 months ago

SUMMARY:

https://github.com/EightfoldAI/octuple/assets/99700808/c7234d8b-31ad-46c6-8f4e-0b279093cf50

JIRA TASK (Eightfold Employees Only):

ENG-80060

CHANGE TYPE:

TEST COVERAGE:

TEST PLAN:

Pull the PR branch and run yarn and yarn storybook. Verify the Drawer stories behave as expected.

codesandbox-ci[bot] commented 3 months ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 71.37931% with 83 lines in your changes are missing coverage. Please review.

Project coverage is 84.20%. Comparing base (bb17b93) to head (96c5f50).

:exclamation: Current head 96c5f50 differs from pull request most recent head 0ec3cd7. Consider uploading reports for the commit 0ec3cd7 to get more accurate results

Files Patch % Lines
src/components/Drawer/Drawer.tsx 71.34% 50 Missing and 1 partial :warning:
src/components/Drawer/Hooks/useDrawer.tsx 49.18% 31 Missing :warning:
src/shared/FocusTrap/FocusTrap.tsx 85.71% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #795 +/- ## ========================================== - Coverage 84.38% 84.20% -0.18% ========================================== Files 1009 1054 +45 Lines 19909 20181 +272 Branches 7546 7628 +82 ========================================== + Hits 16800 16994 +194 - Misses 3025 3103 +78 Partials 84 84 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.