search

EightfoldAI / octuple

The Octuple component library
MIT License
16 stars 45 forks source link

Default panel header should implement a semantic header element #797

Closed jhoward-eightfold closed 3 months ago

jhoward-eightfold commented 3 months ago

Screenshot 2024-03-18 at 2 38 28 PM

currently its just a styled div. Likely we should wrap it in an h1 since its the main head of the panel which would be focus trapped.

Customer requested fix: https://eightfoldai.atlassian.net/browse/ENG-79817

jhoward-eightfold commented 3 months ago

title takes a react node. Going to leverage this locally instead as would probably be necessary to do so in vscode anyway because of style conflicts.