fix: card: types file cleanup and enable string dimension types via string union

EightfoldAI / octuple

The Octuple component library

MIT License

16 stars 45 forks source link

fix: card: types file cleanup and enable string dimension types via string union #800

Closed dkilgore-eightfold closed 3 months ago

dkilgore-eightfold commented 3 months ago

SUMMARY:

Removes unused import
fixes typos
Enable string dimensions, e.g. ("100%", "auto") via type union update to height and width props

JIRA TASK (Eightfold Employees Only):

ENG-83184

CHANGE TYPE:

[x] Bugfix Pull Request
[ ] Feature Pull Request

TEST COVERAGE:

[x] Tests for this change already exist
[ ] I have added unittests for this change

TEST PLAN:

Pull the PR branch and run yarn and yarn storybook. Verify the Card stories behave as expected.

codesandbox-ci[bot] commented 3 months ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.38%. Comparing base (eabad99) to head (82da37c).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #800 +/- ## ========================================== - Coverage 84.38% 84.38% -0.01% ========================================== Files 1009 1009 Lines 19896 19896 Branches 7540 7540 ========================================== - Hits 16790 16789 -1 - Misses 3023 3024 +1 Partials 83 83 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.