fix: grid: omit some attributes to avoid upstream linter errors when node lts

dkilgore-eightfold commented 3 months ago

SUMMARY:

Row and Col raise VS Code linter errors in React 18 + node 20 projects, omitting these, defining and making them optional should fix the issue.

JIRA TASK (Eightfold Employees Only):

ENG-83189

CHANGE TYPE:

[x] Bugfix Pull Request
[ ] Feature Pull Request

TEST COVERAGE:

[x] Tests for this change already exist
[ ] I have added unittests for this change

TEST PLAN:

Pull the PR branch and run yarn and yarn storybook. Verify the Grid stories behave as expected.

codesandbox-ci[bot] commented 3 months ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.38%. Comparing base (49526e9) to head (798549d).

:exclamation: Current head 798549d differs from pull request most recent head a779721. Consider uploading reports for the commit a779721 to get more accurate results

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #801 +/- ## ======================================= Coverage 84.38% 84.38% ======================================= Files 1009 1009 Lines 19901 19896 -5 Branches 7545 7540 -5 ======================================= - Hits 16793 16790 -3 + Misses 3024 3023 -1 + Partials 84 83 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dkilgore-eightfold commented 3 months ago

Turns out this is a known React 18 typing issue --> https://github.com/recharts/recharts/issues/4382

EightfoldAI / octuple