fix: select: address selector scoping bugs when portal and right icon and export type

EightfoldAI / octuple

The Octuple component library

MIT License

16 stars 45 forks source link

fix: select: address selector scoping bugs when portal and right icon and export type #802

Closed dkilgore-eightfold closed 3 months ago

dkilgore-eightfold commented 3 months ago

SUMMARY:

Fixes bug where selected option styles were not being applied when dropdownProps={{ portal: true }} due to scoping
Fixes bug where right icon when present overlaps Select chevron if Select is filterable and clearable

JIRA TASK (Eightfold Employees Only):

ENG-83195

CHANGE TYPE:

[x] Bugfix Pull Request
[ ] Feature Pull Request

TEST COVERAGE:

[x] Tests for this change already exist
[ ] I have added unittests for this change

TEST PLAN:

Pull the PR branch and run yarn and yarn storybook. Verify the Select stories behave as expected.

codesandbox-ci[bot] commented 3 months ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.37%. Comparing base (4b121f4) to head (0670f8e).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #802 +/- ## ========================================== - Coverage 84.38% 84.37% -0.01% ========================================== Files 1009 1009 Lines 19896 19896 Branches 7540 7540 ========================================== - Hits 16789 16788 -1 - Misses 3024 3025 +1 Partials 83 83 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.