fix: a11y: card focus visible styles and aria label placeholders with additional code cleanup

dkilgore-eightfold commented 3 months ago

SUMMARY:

Adds aria label props and placeholders to Select and Input buttons
Adds focus-visible styles to Card and an insetFocusVisible prop
Loosens-up role prop of SkillTag to consider select scenarios
Makes children prop of Dropdown optional and marks it as deprecated
Adds role prop to SearchBox so that it may be configured
Exports CheckBoxValueType

JIRA TASK (Eightfold Employees Only):

ENG-84999

CHANGE TYPE:

[x] Bugfix Pull Request
[ ] Feature Pull Request

TEST COVERAGE:

[x] Tests for this change already exist
[ ] I have added unittests for this change

TEST PLAN:

Pull the PR branch and run yarn and yarn storybook. Verify the Card, Select, SearchBox, SkillTag, TextInput, and Dropdown stories behave as expected.

codesandbox-ci[bot] commented 3 months ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 84.38%. Comparing base (af9f076) to head (3a0a03e).

Files	Patch %	Lines
src/components/Select/Select.tsx	33.33%	1 Missing and 1 partial :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #806 +/- ## ========================================== - Coverage 84.38% 84.38% -0.01% ========================================== Files 1009 1009 Lines 19896 19901 +5 Branches 7540 7545 +5 ========================================== + Hits 16790 16793 +3 - Misses 3023 3024 +1 - Partials 83 84 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

EightfoldAI / octuple