feat: ssr: improve ssr support via globalobject this and use client strings - Githubissues

EightfoldAI / octuple

The Octuple component library

MIT License

16 stars 45 forks source link

feat: ssr: improve ssr support via globalobject this and use client strings #810

Closed dkilgore-eightfold closed 2 months ago

dkilgore-eightfold commented 2 months ago

SUMMARY:

Adds 'use client'; string to component files
Updates webpack to output globalObject: 'this'
Adds comments

JIRA TASK (Eightfold Employees Only):

ENG-85282

CHANGE TYPE:

[ ] Bugfix Pull Request
[x] Feature Pull Request

TEST COVERAGE:

[ ] Tests for this change already exist
[ ] I have added unittests for this change

TEST PLAN:

Pull the PR branch and run yarn and yarn storybook. Verify all components behave as expected.

Generate a local tarball using this guidance (internal only) --> https://eightfoldai.atlassian.net/l/cp/p2HdQHfh

clone https://github.com/EightfoldAI/qa-octuple

Read its README to learn about running the project locally

run yarn add <path to tarball> in the qa-octuple dir

run the project to ensure it runs using your new tarball

run yarn build to test nextjs build process.

codesandbox-ci[bot] commented 2 months ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.