Closed dkilgore-eightfold closed 2 months ago
The onClick event was deferred to the ...rest spread via MenuItemButton props, this caused a regression in Menu as the onClick callback was being used internally to trigger Menu onChange callback upstream.
onClick
...rest
MenuItemButton
Menu
onChange
BEFORE FIX:
https://github.com/EightfoldAI/octuple/assets/99700808/e1cebfff-6772-45c4-895e-072e7751eb24
AFTER FIX:
https://github.com/EightfoldAI/octuple/assets/99700808/87acf590-855b-4c8a-8eb0-fcc3a2eb27e8
ENG-85650
Pull the PR branch and run yarn and yarn storybook. Verify the Menu stories behave as expected.
yarn
yarn storybook
This pull request is automatically built and testable in CodeSandbox.
To see build info of the built libraries, click here or the icon next to each commit SHA.
SUMMARY:
The
onClick
event was deferred to the...rest
spread viaMenuItemButton
props, this caused a regression inMenu
as theonClick
callback was being used internally to triggerMenu
onChange
callback upstream.BEFORE FIX:
https://github.com/EightfoldAI/octuple/assets/99700808/e1cebfff-6772-45c4-895e-072e7751eb24
AFTER FIX:
https://github.com/EightfoldAI/octuple/assets/99700808/87acf590-855b-4c8a-8eb0-fcc3a2eb27e8
JIRA TASK (Eightfold Employees Only):
ENG-85650
CHANGE TYPE:
TEST COVERAGE:
TEST PLAN:
Pull the PR branch and run
yarn
andyarn storybook
. Verify theMenu
stories behave as expected.