feat: accordion: deep accessibility updates - Githubissues

EightfoldAI / octuple

The Octuple component library

MIT License

16 stars 45 forks source link

feat: accordion: deep accessibility updates #823

Closed dkilgore-eightfold closed 1 month ago

dkilgore-eightfold commented 2 months ago

SUMMARY:

Removes multiple click target concern by moving overall clickable area inside the header, under the content via zIndex
Updates focus-visible styles to work with the new layout
Accounts for custom interactive content via selectors, such that it remains selectable or clickable
Checks if custom content is a string, wraps it in a span so it remains selectable
Removes a duplicate {...expandButtonProps} attribute
Updates unit tests
Updates stories

Lighthouse report: accordionDeepA11yPassLighthouse

Axe report: accordionDeepA11yPassAxe

JIRA TASK (Eightfold Employees Only):

ENG-87358

CHANGE TYPE:

[x] Bugfix Pull Request
[x] Feature Pull Request

TEST COVERAGE:

[ ] Tests for this change already exist
[x] I have added unittests for this change

TEST PLAN:

Pull the PR branch and run yarn and yarn storybook. Verify the Accordion stories behave as expected.

codesandbox-ci[bot] commented 2 months ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.