fix: carousel and tooltip: preventTouchMoveDefault false for tooltips inside carousels

gclark-eightfold commented 2 months ago

SUMMARY:

Fixes an issue on mobile / touch devices where the tooltip preventTouchMoveDefault behavior would prevent carousels from being draggable.
Fixes the JSDoc annotation for the tooltip touchInteraction prop to correctly reflect the default: TooltipTouchInteraction.TapAndHold

NOTE: Once this is released in a new version, https://github.com/EightfoldAI/vscode/pull/58487 and https://github.com/EightfoldAI/vscode/pull/58660 can & should be reverted.

GITHUB ISSUE (Open Source Contributors)

N/A

JIRA TASK (Eightfold Employees Only):

https://eightfoldai.atlassian.net/browse/ENG-86212

CHANGE TYPE:

[x] Bugfix Pull Request
[ ] Feature Pull Request

TEST COVERAGE:

[ ] Tests for this change already exist
[x] I have added unittests for this change

TEST PLAN:

Load the Octuple storybook for Carousel on a mobile device, or on desktop using the mobile view inside of the Chrome Dev Tools (⌘ ⇧ M) In the new "Scroller with Tooltips" story:

[ ] Tapping on the text inside the card shows a tooltip with the same text.
[ ] Pressing on the text and dragging left/right moves the carousel cards.

codesandbox-ci[bot] commented 2 months ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.30%. Comparing base (f83eade) to head (9ff41ad).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #825 +/- ## ========================================== + Coverage 84.29% 84.30% +0.01% ========================================== Files 1057 1058 +1 Lines 20320 20331 +11 Branches 7679 7682 +3 ========================================== + Hits 17128 17140 +12 + Misses 3108 3107 -1 Partials 84 84 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

EightfoldAI / octuple