fix: tab: fixes stat tabs word wrap and spacing when border is false - Githubissues

EightfoldAI / octuple

The Octuple component library

MIT License

16 stars 45 forks source link

fix: tab: fixes stat tabs word wrap and spacing when border is false #826

Closed dkilgore-eightfold closed 2 months ago

dkilgore-eightfold commented 2 months ago

SUMMARY:

Updates Stat Tabs layout fixing line clamp word break bug and insets. Addresses TODOs noted here.

Removes horizontal padding when bordered is false, but preserves vertical padding to preserve existing layouts
Removes internal margin-left and margin-right from first and last Stat when bordered is false
Moves word-break: break-all; to only apply when lineClamp is active

Before: opportunity

After: afterFixup

JIRA TASK (Eightfold Employees Only):

ENG-87058

CHANGE TYPE:

[x] Bugfix Pull Request
[ ] Feature Pull Request

TEST COVERAGE:

[x] Tests for this change already exist
[ ] I have added unittests for this change

TEST PLAN:

Pull the PR branch and run yarn and yarn storybook. Verify the Stat Tabs stories behave as expected.

codesandbox-ci[bot] commented 2 months ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.