chore: hooks: improve overall unit test coverage and remove unused hooks - Githubissues

EightfoldAI / octuple

The Octuple component library

MIT License

16 stars 45 forks source link

chore: hooks: improve overall unit test coverage and remove unused hooks #835

Closed dkilgore-eightfold closed 1 month ago

dkilgore-eightfold commented 1 month ago

SUMMARY:

Removes unused hooks (no references in Octuple or vscode apps) useAccessibility, useEffectOnlyOnUpdate, and useFontSize. These hooks were disregarded in favor of alternative solutions.
Adds unit tests to all remaining hooks under src/hooks

JIRA TASK (Eightfold Employees Only):

ENG-90847

CHANGE TYPE:

[x] Bugfix Pull Request
[ ] Feature Pull Request

TEST COVERAGE:

[ ] Tests for this change already exist
[x] I have added unittests for this change

TEST PLAN:

Pull the PR branch and run yarn and yarn storybook. Run yarn test to ensure all UTs pass.

codesandbox-ci[bot] commented 1 month ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.