search

EightfoldAI / octuple

The Octuple component library
MIT License
16 stars 45 forks source link

fix: inlinesvg: adds cross fetch dep to avoid fetch api reference errors #842

Closed dkilgore-eightfold closed 1 month ago

dkilgore-eightfold commented 1 month ago

SUMMARY:

The fetch API is supported by browsers, but when running Jest using older Node versions, it throws null reference errors as the API is not supported. The cross-fetch dep fixes this.

JIRA TASK (Eightfold Employees Only):

ENG-91718

CHANGE TYPE:

TEST COVERAGE:

TEST PLAN:

Pull the PR branch and run yarn and yarn storybook. Verify the InlineSvg stories behave as expected.

codesandbox-ci[bot] commented 1 month ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.