Closed GoogleCodeExporter closed 8 years ago
Original comment by Persh...@gmail.com
on 15 Oct 2008 at 2:47
Use this .patch instead, I forgot to include items.dm on the first one.
Original comment by nave...@gmail.com
on 15 Oct 2008 at 3:02
Attachments:
Great first patch, thanks for contributing. I made a couple modifications as
explained below; please note binary files (items.dmi) don't transfer in patch
files
(you need to upload them seperately).
atoms.dm: var/on moved to end of type declaration
- new variables should generally be declared at the end of a type
- obviously many declarations don't obey this 'rule' at present
items.dm: inserted newlines in super-long string
- makes reading and understanding the function much easier
equipment.dm: reduced tab on return 0
- the desired behavior is to see if ANY jammer is active, not (as the code did)
just
the first encountered
var.dm: removed extra variable
- not used
newitems.dm: removed /process()
- empty function removed
verbs.dm: replaced "Tracking error." with "Tracking Error"
- remove punctuation to potentially chain with other text (not a sentence)
newitems.dm: replaced "Tracking error!" with "Tracking Error"
- consistency with previous text
newitems.dm: removed return statement
- open ended design pre-supposes possibility of more than one AI
- desired behavior is to stop ALL AIs who might be tracking
Original comment by KelsonG...@gmail.com
on 15 Oct 2008 at 3:19
Attachments:
[deleted comment]
I thought I did a couple of those fixes in my second upload, oh well. Thanks
for the
help, Kelson.
Original comment by nave...@gmail.com
on 15 Oct 2008 at 4:31
Attachments:
This patch doesn't entirely "make sense" given rev 572, but the functionality is
valuable even without traitors in the (current) game. Please comment on your
notable
changes in a concise manner as well, so others can tell what areas were
modified in
what area.
Relevant Changes: (Patch by Navee)
- added /obj/item/weapon/jammer
- CameraInvisible added to camera functions
- improved formatting for syndicate radio (code-side)
- standardized error message for those jamming cameras ("Tracking Error")
Committed in rev 575
Original comment by KelsonG...@gmail.com
on 26 Oct 2008 at 5:34
Original issue reported on code.google.com by
nave...@gmail.com
on 15 Oct 2008 at 2:45Attachments: