Ein-Linet / ss13

Automatically exported from code.google.com/p/ss13
0 stars 0 forks source link

Flamethrowers #321

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
Here is my patch for flamethrowers.

Original issue reported on code.google.com by kremvax.chernenko on 4 Jan 2009 at 3:50

Attachments:

GoogleCodeExporter commented 8 years ago
While there were a few issues, thanks for contributing. I took your code, put 
it in
unstable, then attached the below patch for quick reference. A couple items 
quick
suggestions...

- Always provide a reversion/branch where possible (your code was semi-clearly 
/stable)
- Use an svn utility to create patches (like the attached via TortoiseSVN)
- Only item declarations are located in atoms.dm; functions are demo.dm
- Your code creates plasma out of nowhere (throw_amount < 
gas.plasma*gas.temp/25)

Good first attempt and I'd love to see the icons you mentioned. Please feel 
free to
hit me up on IRC!

Original comment by KelsonG...@gmail.com on 7 Jan 2009 at 1:52

Attachments:

GoogleCodeExporter commented 8 years ago
Last time I sent Persh a patch he didn't like it.

Original comment by kremvax.chernenko on 7 Jan 2009 at 3:53

GoogleCodeExporter commented 8 years ago
Patches are good for this kind of site (particularly for referring back to old 
patches)

Original comment by KelsonG...@gmail.com on 7 Jan 2009 at 4:48