finish and save after "move points" edit sometimes resets to old map

[disaster123]

Hi,

i was extensively using the move points function today. And pretty often (2 out of 10 times) finish and save resets to the old map and i've to redone the work.

[EinEinfach]

If you leaving "move points" mode? Or if you save changed map?

[disaster123]

If I try to save changed map - it sometimes resets to original map just before pressing save button

[EinEinfach]

But you left move points mode before save?

[disaster123]

Yes I did

[EinEinfach]

I don't know why but I will check that

[disaster123]

It looks like a race condition like it reloads the original map just before clicking save

[EinEinfach]

I activate interval update after leaving moving mode, maybe it comes faster then reshaping made changes

[EinEinfach]

I tried to locate the problem, but I didn't find any issues in logic behavior. Do you have a log file from your session?

[EinEinfach]

I have another idea why this could happen. If an invalid polygon is created during the point movement (e.g., lines crossing over each other), then the change is discarded and reverted to the original polygon. But this is not a bug.

[disaster123]

OK - i'm going to try to reproduce it and i'm going to close this issue right now. Thanks a lot!

[ShadedSelf]

Same here, the moment save and finish is clicked the perimeter goes back to the way it was. It only works if there is no perimeter selected on the select map popup.

[EinEinfach]

With last commit it shouldn't be happen anymore

[ShadedSelf]

Im on master, log doesnt say anything either

[EinEinfach]

What do you exactly do?

[ShadedSelf]

• Go to mapping page
• Select a perimeter to be edited
• Add a shape/remove a shape/change a point, all of them show the same behaviour
• Click save and finish

Then while the popup to set a name is active you can see the perimeter reverting itself to how it was before the changes, if you dont do step 2 it works as expected.

[EinEinfach]

try now

[ShadedSelf]

Yup, seems fixed now.

[EinEinfach]

Some callbacks I'll never understand