EinStack / glide

🐦 A open blazing-fast simple model gateway for rapid development of production GenAI apps
https://docs.einstack.ai/glide/
Apache License 2.0
113 stars 18 forks source link

🔧 #221 Add B3 propagator #242

Closed gernest closed 1 month ago

gernest commented 1 month ago

Followup to #221

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.05%. Comparing base (8b420f7) to head (636606d).

:exclamation: Current head 636606d differs from pull request most recent head de6047c. Consider uploading reports for the commit de6047c to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #242 +/- ## ======================================== Coverage 67.04% 67.05% ======================================== Files 78 78 Lines 3602 3603 +1 ======================================== + Hits 2415 2416 +1 Misses 1058 1058 Partials 129 129 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

gernest commented 1 month ago

@roma-glushko any ideas on the ci failure?

roma-glushko commented 1 month ago

@gernest

any ideas on the ci failure?

yes, I do, webhook URL was not passed correctly (empty) for your PRs for some reason:

2024-05-05_23-20-19

Ignore it for now, I will be investigating why this is a case

roma-glushko commented 1 month ago

GH actions don't share secrets with forks https://github.com/orgs/community/discussions/26163 bummer. This makes implementing notifications more challenging 😌

roma-glushko commented 1 month ago

@gernest I have changed the trigger for that action in https://github.com/EinStack/glide/pull/244 Could you please pull that change and see if that makes any difference? 🙏

gernest commented 1 month ago

@roma-glushko I pulled the changes PTAL