search

EinStack / glide

🐦 A open blazing-fast simple model gateway for rapid development of production GenAI apps
https://docs.einstack.ai/glide/
Apache License 2.0
127 stars 20 forks source link

🔧 [Telemetry] Span & metrics exporting should be disabled by default #248

Closed roma-glushko closed 4 months ago

roma-glushko commented 4 months ago

Tracing and metrics should be optional and disabled by default in case people don't have a backend to export them and view:

2024-05-06_22-52-50

roma-glushko commented 4 months ago

cc @gernest

gernest commented 4 months ago

Probably you have otel envs setup . Default providers are none. which is a noop provider. Looks like you have otel configured pointing to localhost:4314/v1/metrics ? the port looks like from victoria metrics or something?

You can close this, it is not a glide issue.

gernest commented 4 months ago

@roma-glushko did you check otel env vars? Just needs to make sure this is not an issue, before I start instrumentation this weekend.

roma-glushko commented 4 months ago

@gernest I don't think I have any OTEL_* env variables set. This is reproducible when I just start a dev process via make run and then execute some workflows like chat requests, then after some time I start seeing this warning.

In that workflow, I don't any environment variables other than provider's API keys.

roma-glushko commented 4 months ago

Tracing and metrics should be disabled by default as they require special tools to take advantage of them and we have no assumptions/requirements around users having that in place. If I just install Glide via brew and start the process with a simple config, there should no warnings about inability to export metrics or traces and there would no additional environment variables to setup observability (unless the user goes for that after some time playing around with Glide).

gernest commented 4 months ago

I was able to reproduce this locally, will work on a fix.