EinStack / glide

🐦 A open blazing-fast simple model gateway for rapid development of production GenAI apps
https://docs.einstack.ai/glide/
Apache License 2.0
127 stars 20 forks source link

#238 Make all durations human-readable when marshalling json/yaml #250

Closed daesu closed 4 months ago

daesu commented 4 months ago

Render all Durations like retry.min_delay, retry.max_delay, client.timeout as human-friendly strings (e.g. 5s) by custom marshalling.

image

roma-glushko commented 4 months ago

Hey Paul, this is good generally speaking, but have you seen this custom type used in some other places? https://github.com/EinStack/glide/blob/45d9aa12816ff5e5009dfdee0e84d627966ab94f/pkg/config/fields/duration.go#L5-L4 I would expect it to be used. Let's have a quick chat in Discord because Pablo seem to go this route already and have a branch

daesu commented 4 months ago

Closed