search

EinfachHans / capacitor-email-composer

E-Mail Composer Plugin for Capacitor
MIT License
21 stars 7 forks source link

feat: add isHtml property #4

Closed tobium closed 2 years ago

tobium commented 2 years ago

I added html support

EinfachHans commented 2 years ago

What about Android? Is there a similar opportunity?

tobium commented 2 years ago

added html support for android as well

EinfachHans commented 2 years ago

@tobium amazing. Please add a short code snippet of the usage and two screenshots (ios / android) of the final html formated email that opens in the email app, than this is ready to go

tobium commented 2 years ago

Could we please skip it? Because "isHtml" is only a new flag which is documented in the readme file and I'm not able now to make screenshots specially for android. But I can later do it when I can use this plugin in our product.

EinfachHans commented 2 years ago

No, before adding new features i would be sure that they work 😃

tobium commented 2 years ago

But I dont' have an android app to test it now.

EinfachHans commented 2 years ago

Simulator?

tobium commented 2 years ago

Android: Screenshot_20211018-122905

tobium commented 2 years ago

iOS: Bildschirmfoto 2021-10-18 um 12 38 38

EinfachHans commented 2 years ago

This seems not to work on android? 😃

tobium commented 2 years ago

code snippet:

const html = "<html><h1>HTML eMail</h><p>This is a test.</p></html>";

 EmailComposer.open({
              to: ['test@test.com'],
              subject: 'Test',
              body: html,
              isHtml: true
            })
tobium commented 2 years ago

This seems not to work on android? 😃

sure, the HTML tags are not shown...so the HTML is rendered, but the < h1 > tag which I used is rendered very similar to the < p > tag

tobium commented 2 years ago

can we finish this PR now?