search

EinfachHans / cordova-plugin-advanced-imagepicker

Cordova Plugin for an advanced (multiple) ImagePicker
29 stars 48 forks source link

(feature-request): Add ability to configure all YT Video Options #23

Closed AdlerJS closed 3 years ago

AdlerJS commented 3 years ago

Feature request

@EinfachHans our QA found a bug where they were trying to upload / pick videos longer than 60 seconds but still under our 150 MB limit. The YT package on IOS gives the error "Pick a Video that is less than 60.0 seconds long" via a popup. After doing some research it seems this is the default setting for the config.video. I see we have an option to override compression just wondering the effort to get the following added to be able to override all video options as shown below

config.video.compression = AVAssetExportPresetHighestQuality
config.video.fileType = .mov
config.video.recordingTimeLimit = 60.0
config.video.libraryTimeLimit = 60.0
config.video.minimumTimeLimit = 3.0
config.video.trimmerMaxDuration = 60.0
config.video.trimmerMinDuration = 3.0
EinfachHans commented 3 years ago

PR's are highly welcome

AdlerJS commented 3 years ago

@EinfachHans finally got around to creating the PR / writing the code for this. But do not have write access even on a separate branch on this repo. Is it possible to add me to avoid having to create a fork. Thanks!

EinfachHans commented 3 years ago

@danbunkr pls create a Fork, you can delete the forked repository after the PR is merged 😊

AdlerJS commented 3 years ago

See: https://github.com/EinfachHans/cordova-plugin-advanced-imagepicker/pull/24

EinfachHans commented 3 years ago

Thanks for your PR. 😊 This is released in 1.5.0