EionRobb / funyahoo-plusplus

A replacement Yahoo prpl (protocol plugin) for Pidgin/libpurple
GNU General Public License v3.0
59 stars 11 forks source link

Some people show up multiple times #2

Open Zombie-Ryushu opened 8 years ago

Zombie-Ryushu commented 8 years ago

Some people show up multiple times in Yahoo. Two or three Copies of the same person appear, with the same name or ID.

EionRobb commented 8 years ago

This 'might' have been fixed in https://github.com/EionRobb/funyahoo-plusplus/commit/f60b3e11a38c0bb7275b5ebe259f3cd7a9e54640 which was trying to add the "yahoo" group to the buddy list multiple times

wolfy67 commented 8 years ago

I see the same problem, using 48430a30045612d2b85d4045bff4aded9f69adcb

rhester72 commented 8 years ago

Ditto - in Bitlbee, all show up under 'yahoocom' (by login/e-mail address) under 'eionrobb-funyahoo-plusplus' (by Yahoo nickname). More interestingly, my own Yahoo account shows up twice - apparently I message myself frequently ;)

Very interestingly, the 'mirrors' of the users show up with entirely different "hex IDs".

alexolog commented 8 years ago

I think it's one of the issues I mentioned in #19

msdobrescu commented 8 years ago

I have this, but just one of the three actually works for chatting.

EionRobb commented 8 years ago

This looks like it's to do with the way we rename users in the buddy list.

When you add a buddy, eg with their old yahoo messenger ID, it goes through a few renames on the server to get a temporary Base32 ID and end up with the actual Base32 ID. There's potential there to end up with duplicates in the ~/.purple/blist.xml file depending on the order of events coming back from the server - but only one of the dups will have the 'groupId' setting and thus only one dup will be able to have messages sent to them.

Instead of doing a buddy list rename, we should be doing a conversation rename, and removing the old buddy and re-adding the new one. Perhaps storing a list of temporary buddy ids temporarily to not store the bad buddys to the buddy list?

Bearded-Blunder commented 8 years ago

my own Yahoo account shows up twice - apparently I message myself frequently ;)

I'll see your twice, and raise you three times