search

EionRobb / icyque

ICQ WIM protocol for libpurple
GNU General Public License v3.0
73 stars 15 forks source link

Pidgin crashes on send message #39

Closed denovoid closed 4 years ago

denovoid commented 4 years ago

As of yesterday my Pidgin (2.13.0) crashes each time I send a message through ICQ. This occurs whether I send a message from the computer or from the ICQ app on my phone. Is anyone else experiencing this problem? I suspect some change at ICQ's side.

TeaObvious commented 4 years ago

Have the same issue and updating to master caused me to get "Failed to acquire authentication token (robusto)."

Edit: With the merge of 513fc162d5d1a201c2b044e2b42941436d1069d5 it pidgin does not crash and the robusto issue ist not present.

denovoid commented 4 years ago

I am using the Windows pre-compiled version -- is there anything I can do ?

EionRobb commented 4 years ago

@denovoid can you get a backtrace? https://developer.pidgin.im/wiki/GetABacktrace

@Legodev are you saying that master does or doesn't crash? That commit was merged into master already

TeaObvious commented 4 years ago

@Legodev are you saying that master does or doesn't crash? That commit was merged into master already

Master does NOT crash.

EionRobb commented 4 years ago

@Legodev "and the robusto issue is not present"? So master works ok for that too?

TeaObvious commented 4 years ago

with the current master the robusto issue is present in master and was introduced with the merge: 8347afc70eb71e3a4bb139a62faa7024ba9070db

side note: i have an old icq account without any phone number/sms/what ever attached. it works with the state before the merge 8347afc70eb71e3a4bb139a62faa7024ba9070db

TeaObvious commented 4 years ago

@EionRobb i found the robusto issue on my end. State of master (for me): No crash and no robusto issue. Sorry for being leading you on a possible wrong track! :(

My issue was: After reading the commit that caused the robusto issue for me, i noticed that there are many new interactions with the time for example the usage of ia->server_time_offset. Therefore i figured it might be a time related issue on my end...

In short: The robusto issue was caused by broken timezone settings, which lead to that some applications, the clock of my desktop environment was not part of it, were not able to read the correct time.

denovoid commented 4 years ago

@EionRobb
Today, in finding the pidgin.RPT file I noticed a number of references in the Call stack list there to ...\plugins\Copy of libicyque.dll such as 65484086 C:\Program Files\Pidgin\plugins\Copy of libicyque.dll icq_process_event C:\cygwin\home\Eion\icyque/libicyque.c:1011

When I previously updated the libicyque.dll file in June 2019 to the current 257,774 byte version, I renamed the previous 251,681 byte version to 'Copy of libicyque.dll' and left it in the plugins folder. I imagined dropping in the new file of the same name would be sufficient to have it used, but from the RPT file it seems the program has still been referencing the old file somehow, even though renamed, for the best part of a year, with no previous ill-effects.

So I have just now removed the 'Copy of...' file, and re-run Pidgin and after a hiccuped first attempt, it seemed to pick up the new libicyque.dll and the ICQ crashing issue has now disappeared.

All sent messages are now still subject to showing twice in the client window, whereas before it was only sometimes, but that's another issue.

Thanks for pointing me at trying to get a backtrace :)