EionRobb / pidgin-win7

A plugin to add Windows eye-candy to Pidgin (jump lists, transfer progress, status emblems)
11 stars 4 forks source link

Crash on receipt of files without transfer window open. #4

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Open a conversation
2. Get your buddy to send a file, without opening the file transfers window.

What is the expected output? What do you see instead?
The file to be transferred. Pidgin crashes instead.

What version of the product are you using? On what operating system?
SVN trunk@HEAD :)

Please provide any additional information below.
Patch attached.

Original issue reported on code.google.com by lowj...@users.sourceforge.net on 12 Jan 2011 at 1:25

GoogleCodeExporter commented 9 years ago
Index: pidgin-win7.c
===================================================================
--- pidgin-win7.c   (revision 31)
+++ pidgin-win7.c   (working copy)
@@ -1123,6 +1129,8 @@
    struct _PidginXferDialog *xfer_dialog;

    xfer_dialog = pidgin_get_xfer_dialog();
+   if (!xfer_dialog)
+       return NULL;

    ft_window = GDK_WINDOW_HWND(gtk_widget_get_window(xfer_dialog->window));

Original comment by lowj...@users.sourceforge.net on 12 Jan 2011 at 1:25

GoogleCodeExporter commented 9 years ago
This issue was closed by revision r32.

Original comment by eionrobb on 12 Jan 2011 at 9:53

GoogleCodeExporter commented 9 years ago
Issue 10 has been merged into this issue.

Original comment by eionrobb on 7 Feb 2011 at 10:48