search

EionRobb / purple-discord

A libpurple/Pidgin plugin for Discord
GNU General Public License v3.0
371 stars 42 forks source link

Room auto-creation stopped working #284

Open LurkerHub opened 4 years ago

LurkerHub commented 4 years ago

I renamed my blist.xml aand ticked the room auto-creation. After restarting Pidgin, only one server out of about 25 was picked up.

LurkerHub commented 4 years ago

Interestingly, the server that was picked up also shows presence in rooms. Possibly the old code is sent for some servers and the new code for others? Both need to be supported if that is the case.

alexolog commented 4 years ago

Any comments?

alexolog commented 4 years ago

This is a significant issue for me. All my room definitions in all servers got nuked and adding all of them manually is not feasible. I can no longer use Pigin for Discord group chat.

Is there any idea how this can be fixed?

LurkerHub commented 4 years ago

This is a significant issue for me. All my room definitions in all servers got nuked and adding all of them manually is not feasible. I can no longer use Pigin for Discord group chat.

Is there any idea how this can be fixed?

Don't hold your breath.

https://www.reddit.com/r/pidgin/comments/fsl94b/discord_plugin_can_no_longer_autocreate_rooms/

EionRobb commented 4 years ago

So I don't use this feature myself, but if someone is able to test the above commit (also available in the nightly dll) and give some feedback, that would be appreciated

LurkerHub commented 4 years ago

Confirmed fixed. Thank you!

What was the problem?

EionRobb commented 4 years ago

I guess the code to add non-DM channels to the buddy lost got accidentally removed at some point, or it assumed that the server would send it as an event, which never happened.

Moved the "add channels to buddy list" code to just after the account is declared to be connected

alexolog commented 4 years ago

Works for me as well Thanks Rob

sebbu2 commented 4 years ago

thx, works for me too. It just always open all group/channel whenever someone talks, instead of only on mentions :(