search

EionRobb / purple-googlechat

A Google Chat protocol plugin for libpurple/Pidgin/bitlbee/whatever
GNU General Public License v3.0
112 stars 13 forks source link

When sending messages, don't force RetentionState to PERMANENT #49

Closed steven676 closed 2 years ago

steven676 commented 2 years ago

This allows sending messages to conversations where history is off. Lightly tested with DMs with conversation history both on and off.

Fixes #22, though I don't know if this is how you want to do this (as opposed to fetching the history setting for the conversation and setting RetentionState accordingly).

EionRobb commented 2 years ago

Oh sweet, glad that works. I think when I first got things going, that was required, but if it's not needed now that's a bonus :)

Since the struct is all false by default you can save the extra line, but that works great with the TODO there for future reminders :)

Thank you!

badjer2 commented 2 years ago

This isnt live yet in dll for windows? tried downloading, even deleted the account from pidgin and added it again, but it still doesnt send when history is turned off

EionRobb commented 2 years ago

Apologies, the dll has only updated just now.

badjer2 commented 2 years ago

downloaded dll again today, restarted pidgin, even turned history on-off, still not sending meessages with history off?

pijulius commented 2 years ago

Hi Guys, can confirm this, just cloned the github repo, build it and then tried to send messages with History Turned off and it wasn't working. Then enabled it in gmail/chat window and it's working right away.

badjer2 commented 2 years ago

Apologies, forgot to post, I re-downloaded again on July 2. and now it works even with history turned off