EionRobb / purple-pulsesms

GNU General Public License v3.0
21 stars 2 forks source link

Use something other than homerolled crypto #10

Open GIJack opened 2 years ago

GIJack commented 2 years ago

Hi,

This project uses its own implementation of AES. As you may or may not know, this is a legit bad idea.

Recommended to use openssl, libressl, or other well maintained crypto library that has AES.

EionRobb commented 2 years ago

It's not well documented but it's using the AES lib from https://github.com/kokke/tiny-AES-C/ in order to reduce dependencies and memory usage

Using OpenSSL wasn't an option when the plugin was first written due to GPL compliance, but worth looking at again now that openssl3 is GPL OK