EionRobb / purple-rocketchat

Rocket.Chat Plugin for libpurple
GNU General Public License v3.0
21 stars 2 forks source link

Group-direct-messages are broken #22

Open BenWiederhake opened 3 years ago

BenWiederhake commented 3 years ago

Steps to reproduce:

Expected behavior: A new tab opens in pidgin, and both sent and received messages appear in there and only in there.

Actual behavior: A new tab opens in pidgin, and the sent messages appear in there and only in there. However, the received messages appear as direct messages only from the sending person. So, additionally to the group tab, I also see new tabs with DMs from the people A, B, and C.

EionRobb commented 3 years ago

I've never been in a DM group before, I generally only use the regular group chats, so the code probably assumes that everything is either a public group, or a DM.

Are you able to get a debug log of some messages coming through, or is there a test server I can join to send some test messages to?

BenWiederhake commented 3 years ago

Technically I do have the log messages, but there are NDAs at play, so sending any logs means I have to carefully comb through the logs and err on the side of over-censoring, I don't think they would be useful afterwards. I also don't have a test server readily available, but I could try setting one up (assuming RocketChat really is Free Software as they claim).

Thaodan commented 2 years ago

Technically I do have the log messages, but there are NDAs at play, so sending any logs means I have to carefully comb through the logs and err on the side of over-censoring, I don't think they would be useful afterwards. I also don't have a test server readily available, but I could try setting one up (assuming RocketChat really is Free Software as they claim).

You can use the public rocket server open.rocket.chat. to test.