EionRobb / skype4pidgin

Skype Plugin for Pidgin, libpurple and more
https://github.com/EionRobb/skype4pidgin/tree/master/skypeweb#skypeweb-plugin-for-pidgin
624 stars 88 forks source link

link urls when sent over skypeweb #417

Open urandom2 opened 8 years ago

urandom2 commented 8 years ago

I frequently talk with people via skypeweb that use the official skype client, and they always complain that my url links are never clickable. If I switch over to the official client or the web client, both will create linked urls for my contacts.

Let me know if there is any help you need with reproducing this issue.

EionRobb commented 8 years ago

Hmm. I haven't had problems from the users I send links to. Do you have an example link that doesn't work?

urandom2 commented 8 years ago

If you have the official client on hand, and can spin up a second account, this should be pretty trivial to confirm. Not sure how to test or fix, but you should at least see the same issue. As far as what links, pretty much anything that the official skype client converts (not sure of their regex) is just text when skypeweb sends it. Here are a few confirmed examples.

http://google.com
https://google.com
http://www.amazon.com/Lark-Ro-Womens-Sleeve-Medium/dp/B015667GUE/ref=lp_13631152011_1_1

Also, while testing the following address was never received on the official client, and appears to have been dropped as later messages go through with no issue, and there are no error messages in the bitlbee process that is running skypeweb.

http://www.amazon.com/Lark-Ro-Womens-Sleeve-Medium/dp/B015667GUE/ref=lp_13631152011_1_1?s=apparel&ie=UTF8&qid=1456768473&sr=1-1&nodeID=13631152011
EionRobb commented 8 years ago

Oh, this is a bitlbee thing? Hmm. I guess bitlbee isn't auto-linkifying urls like Pidgin does. I'll see what can be done, but I'm not sure if this will be a plugin thing or a bitlbee thing

urandom2 commented 8 years ago

If this is a bitlbee issue, would it be worthwhile to open up an issue over there?

vitalyster commented 8 years ago

The same issue is in Spectrum. What is the "auto-linkify" function?

ojdo commented 8 years ago

I just encountered a stronger form of this issue: when sending a link with a & in it, the whole message w/ link even got swallowed (=not received by conversation partner) at all. Example:

https://www.youtube.com/watch?v=SinVP29pGqg&t=54
EionRobb commented 8 years ago

@ojdo was that with bitlbee or spectrum that the &'s aren't coming through encoded?

ojdo commented 8 years ago

@EionRobb oh sorry, bad bug report :-( Hopefully better: A message containing a URL with an & is not received by my conversation partner. Interestingly, an isolated ampersand (e.g. foo & bar) is sent without issue.

a13 commented 7 years ago

I have the same issue with non-clickable links sent via bitlbee-purple

ravenexp commented 7 years ago

Same issue with & in URLs. I get "Failure due to: BlockedContent." error message.

heeplr commented 2 years ago

I have the same issue with the current version + spectrum. There are a few things happening here as far as I understand:

Surely bitlbee & spectrum won't begin to auto-linkify URLs just because Skype needs that done serverside.

Maybe the perfect solution would be to move the "auto-linkify" code from pidgin to libpurple and have a config option to disable it? I'm not sure what the best solution to this issue is but it's annoying af! ;)

EDIT: added XMPP clients situation

heeplr commented 1 year ago

Any news on this?

A possible solution might be to introduce a "bridge-compatibility" mode like purple-gowhatsapp does, as I don't see spectrum/bitlbee modifying messages in the future.