search

EionRobb / skype4pidgin

Skype Plugin for Pidgin, libpurple and more
https://github.com/EionRobb/skype4pidgin/tree/master/skypeweb#skypeweb-plugin-for-pidgin
624 stars 88 forks source link

Rooms list lacks a member count #589

Closed bodqhrohro closed 6 years ago

bodqhrohro commented 6 years ago

F.e., for IRC channels the following column is displayed: 2018-02-13-155109_827x396_scrot But there is no such column for Skype group chats. Can it be easily added or it would lead to expensive requests for every chat separately?

lighterowl commented 6 years ago

You're in luck : the number of members is present in the messages supplied by the server. PR #598 solves this .

bodqhrohro commented 6 years ago

Great, it works, thank you. However, not for every chat; some of them, mostly old ones, don't have a counter.

monsta commented 6 years ago

You can close this as https://github.com/EionRobb/skype4pidgin/pull/598 has been merged.

bodqhrohro commented 6 years ago

You can close this as #598 has been merged.

Okay, I made some debugging and now see that old chats just lack the threadProperties.membercount attribute for some reason. So this is probably everything that could be done.

lighterowl commented 6 years ago

Yes, I reached the same conclusion while writing this patch : the server just doesn't return the data for some of the chats. Maybe it would be possible to work around this by asking each room for all the members and then returning the count, but I haven't investigated it further.