search

EionRobb / skype4pidgin

Skype Plugin for Pidgin, libpurple and more
https://github.com/EionRobb/skype4pidgin/tree/master/skypeweb#skypeweb-plugin-for-pidgin
624 stars 88 forks source link

Fix for a file transfer #617

Closed xomachine closed 6 years ago

xomachine commented 6 years ago

As I mentioned in #616, the plugin is crashing when try to send a file. The origin of problem was in error handling code. This PR should fix the error that can not be properly handled by the plugin and does nothing with the error in error handling code itself.

First of all it fixes the "{\\"message\\":\\"PlatformId needs to be specified\\"}" server message by supplying the platform id within the header.

After fixing this problem I've encountered another one: the server does not react on the file transfer performed by ssl code. So I've just switched to purple_http_request_set_contents_reader as it mentioned in TODOs. Now the file transfer works for me.

EionRobb commented 6 years ago

Much cleaner than the raw http :)

EionRobb commented 6 years ago

Thanks! :)