EionRobb / skype4pidgin

Skype Plugin for Pidgin, libpurple and more
https://github.com/EionRobb/skype4pidgin/tree/master/skypeweb#skypeweb-plugin-for-pidgin
624 stars 88 forks source link

Give a detailed login failure message #641

Closed timgws closed 5 years ago

timgws commented 5 years ago

This small change will give you a message and error code back from Skype when the login fails. For example, it will tell you that your account is blocked, or that you are required to enter a 2FA value.

EionRobb commented 5 years ago

Oh nice, that's handy. Would this just be for the non-alternate login?

timgws commented 5 years ago

@EionRobb I believe so.

timgws commented 5 years ago

Here are a list of messages that I have seen:

   * 80041012: Your account or password is incorrect.
   * Login error: Authentication failed. Bad username or password. (code 40120)
   * Login error: Bad username or password (Authentication Failure)
xss commented 5 years ago

Hello Tim. Thank you, yes, that sounds very handy. However, there is a typo error_test vs error_text in skypeweb_login.c that causes the make to fail until corrected. Just as a side note. :)

timgws commented 5 years ago

Ah, sorry about that. I accidentally pushed the unamended commit yesterday.