search

EionRobb / skype4pidgin

Skype Plugin for Pidgin, libpurple and more
https://github.com/EionRobb/skype4pidgin/tree/master/skypeweb#skypeweb-plugin-for-pidgin
625 stars 88 forks source link

Switch BitlBee image message from system to normal IM/Chat #671

Closed jpalus closed 3 years ago

jpalus commented 3 years ago

As far as I could tell from testing and by quick look at code (https://github.com/bitlbee/bitlbee/blob/75222ab2b4542ee8b4726feee0d2c65636e3c7e3/protocols/purple/purple.c#L1182-L1186) BitlBee does not handle PURPLE_MESSAGE_SYSTEM and hence links to images are not visible anywhere. This PR attempts to fix it by posting image URL as normal IM/Chat message. Works for me though admittedly this is my "first time" with libpurple code and might have some issues.

EionRobb commented 3 years ago

That makes sense! Thanks for fixing that :)