search

EionRobb / skype4pidgin

Skype Plugin for Pidgin, libpurple and more
https://github.com/EionRobb/skype4pidgin/tree/master/skypeweb#skypeweb-plugin-for-pidgin
625 stars 88 forks source link

typo in packaging configuration fixed, now builds packages correctly #696

Closed beadon closed 1 year ago

beadon commented 1 year ago

Looks like a few letters were jumbled for some reason. This broke cpack.

Works now!

EionRobb commented 1 year ago

Thanks! 🙂

vitalyster commented 1 year ago

This breaks output filename at least for DEB files

beadon commented 1 year ago

This breaks output filename at least for DEB files

Yes, I noticed that the DEB files are not named properly, but cpack wasn't working AT ALL before this. So I chose to not deep-dive into the reason why the filename was not right.

If you like I can fix the package name too ? It's beyond the scope of just fixing the typo.

vitalyster commented 1 year ago

If the only issue was "generator not specified" you can provide generator on command line, like this cpack -G DEB That "typo" line should be removed at all

beadon commented 1 year ago

If the only issue was "generator not specified" you can provide generator on command line, like this cpack -G DEB That "typo" line should be removed at all

no, your guess was not correct.