Eir-nya / alias

Bind text to short commands that paste in the text quickly and easily.
MIT License
3 stars 0 forks source link

Review before being eligible to powercord-community repo #1

Closed cyyynthia closed 5 years ago

cyyynthia commented 5 years ago

Hi, I reviewed your plugin and there is a few changes that must be done before being able to get a repo on the community org. I tried to provide as much details as possible, as well as some suggestion to improve code quality. Feel free to reply to this issue or ping me on Discord (Bowser65#0001) if you have any questions/fixed all of those! :D

Also english is not my native language, so there might be some mistakes :p

General

Manifest

index.js

Settings.jsx

Pair.jsx

Eir-nya commented 5 years ago

First, thank you so much for reviewing my thing! You've helped a lot <3 This was actually my first time using React.JS! Sorry if it's not professional.

I've fixed most of what you said in my newest commit. But I have a few questions:


I think that's all I wanted to ask! Thank you again! I hope I'm not being troublesome or anything. Powercord's great btw <3

cyyynthia commented 5 years ago

To get access to the 3 props I mentionned you need to pass the raw component in registerSettings (Settings instead of () => React.createElement(Settings). I'll review again soon and bring back a list of fixes you can make. Thanks for the feedback regarding Powercord ❤️

cyyynthia commented 5 years ago

Review version 2.0 I also added checkboxes so you can check stuff if you want to

index.js

Settings.jsx

Pair.jsx

Note that you can use random Discord classes, just dynamically grab them using getModule

Eir-nya commented 5 years ago

Hello again! I fixed everything you said!

I also added support for Light Mode in Commits 3 and 4, which I forgot to do before :)

 

It took me a while to figure out how to do the last one, but then I found a helpful page that taught me that key is a special component in React.js elements. I didn't know, as I'm still pretty new to React.js.

I'm so glad I found it! Thank you so much for helping me!

cyyynthia commented 5 years ago

👀 https://github.com/powercord-community/alias/invitations