Eisa01 / mpv-scripts

This repository contain scripts I have made for mpv media player...
BSD 2-Clause "Simplified" License
505 stars 35 forks source link

Timeline Size Changes When Skipping #112

Open AziRizvi opened 7 months ago

AziRizvi commented 7 months ago

When SmartSkip's Skip to Silence or Skip To Chapter is initiated, the timeline/OSC zooms in, this is not really an issue but more of an annoyance..

I hope this can be addressed in a future update perhaps.

Normal View: JCX

Timeline/OSC zoomed in when skipping: JCX2

Eisa01 commented 7 months ago

Hi @AziRizvi I am aware of the issue, however it is related to the default osc that is bundled with mpv.

It determines the size based on the running video, therefore, once I disable the video for silence-skip, the size changes to the default no-video size. I'd be glad for any contributions from other dev's or guidance from mpv-team regarding this.

AziRizvi commented 7 months ago

Hi @AziRizvi I am aware of the issue, however it is related to the default osc that is bundled with mpv.

It determines the size based on the running video, therefore, once I disable the video for silence-skip, the size changes to the default no-video size. I'd be glad for any contributions from other dev's or guidance from mpv-team regarding this.

There's another MPV script for skipping intros called Skip-Intro.lua, it's function is the same as Detuur's skip to silence, it skips to the the next silent point according to your quietness and duration settings, when using that script, the timeline size remains the same.

Here's the link to the script. https://raw.githubusercontent.com/rui-ddc/skip-intro/master/skip-intro.lua

I'm not exactly sure how it works because I don't know the coding language, but maybe you can take a look and discover something.

Other than that maybe perhaps tag Dyphire and ask him.

Eisa01 commented 7 months ago

I have already checked it out, the script you mentioned works the same way as Detuur's (which creates an issue that could lead to silence being not detected in some cases). This is why I have changed the method after forking Detuur's script.

Also Dyphire contributes randomly but he is not involved in the native osc.lua development (which is the root cause of the issue), so this needs to be communicated directly with mpv team.

The best I can do is open an issue in mpv repository explaining the issue of osc size changing when video is disabled and if that they can provide an option to retain the size.

AziRizvi commented 7 months ago

I have already checked it out, the script you mentioned works the same way as Detuur's (which creates an issue that could lead to silence being not detected in some cases). This is why I have changed the method after forking Detuur's script.

Also Dyphire contributes randomly but he is not involved in the native osc.lua development (which is the root cause of the issue), so this needs to be communicated directly with mpv team.

The best I can do is open an issue in mpv repository explaining the issue of osc size changing when video is disabled and if that they can provide an option to retain the size.

So I guess both the scripts instead of disabling the video used lavfi blackout filters which can sometimes cause the skipping action to never end.

Yes, that would be great, thankyou!

AziRizvi commented 7 months ago

I have already checked it out, the script you mentioned works the same way as Detuur's (which creates an issue that could lead to silence being not detected in some cases). This is why I have changed the method after forking Detuur's script.

Also Dyphire contributes randomly but he is not involved in the native osc.lua development (which is the root cause of the issue), so this needs to be communicated directly with mpv team.

The best I can do is open an issue in mpv repository explaining the issue of osc size changing when video is disabled and if that they can provide an option to retain the size.

Eisa, Is there a way to hide the OSD bar that appears in the middle of the screen when skipping? I want to turn it off, don't want to turn off the text that appears after skipping, just the osd bar when the skipping is happening.

Eisa01 commented 7 months ago

Hi @AziRizvi, Please keep the comments related to the issue only.

And yes, the osd messages are configurarable as described in the conf file.

In SmartSkip.conf

#-- (no-osd/osd-bar/osd-msg/osd-msg-bar). OSD message that will be shown when the script triggers an action
seek_osd=osd-msg-bar
chapter_osd=osd-msg-bar
autoskip_osd=osd-msg-bar

Just change the above to osd-msg without the bar..