search

Eisa01 / mpv-scripts

This repository contain scripts I have made for mpv media player...
BSD 2-Clause "Simplified" License
507 stars 35 forks source link

SmartCopyPaste 3.0: Option to Paste into Playlist by default? #30

Closed MintMain21 closed 2 years ago

MintMain21 commented 2 years ago

Before I upgraded to SCP 3.0, anything I pasted into MPV would be pasted into the playlist by default, which I like. In SCP 3.0 however, the default behavior is to override the current video. I can customize behavior when a video is playing, and when using ctrl+alt+v, but if I have a video paused and use just ctrl+v, it will override my current playlist.

Eisa01 commented 2 years ago

Hmm, I didn't quite fully get it. What is the behavior you are looking for that changed? Also when a video is paused it should append to the playlist and not override it. I thought the same applies to older version?

The only difference I recall from the previous version was that I didn't allow for the same file to be pasted into playlist and gave seeking still running notification, was that important?

MintMain21 commented 2 years ago

Okay, on further testing, the bug only applies when I try to add another YouTube link, but the initial link hasn't fully loaded yet.

Eisa01 commented 2 years ago

Can you compare with the version in the released section, tell me if the older version differed for you or had the same issue?

MintMain21 commented 2 years ago

https://user-images.githubusercontent.com/91362684/147512276-5accde58-6a87-435a-a5c6-d70bbcc449bf.mp4

SmartCopyPaste Before and After. 2.5 vs 3.0.

Eisa01 commented 2 years ago

Interesting, I'll attempt to replicate and hope to fix it by tomorrow

MintMain21 commented 2 years ago

Alright, I decided instead of trying to change the function of default paste, I would just set the Paste-Specific behavior to "Playlist", and then swap the key-combination for normal paste and "Special Paste". Works fine for me. I'll leave this open in the event you want to change this behavior for the default release, otherwise feel free to close this issue.

Edit: Clearly I did not notice when you responded with "I'll attempt to replicate and hope to fix it by tomorrow". :P

Eisa01 commented 2 years ago

Added a line that should fix the issue, test and let me know when you can =)

MintMain21 commented 2 years ago

That fixed it. Thanks.

Eisa01 commented 2 years ago

Glad that it is resolved, thanks for noticing issues with the 3.0 release. Re-wrote most of the script in this version, hopefully no other bugs slipped .