search

Eisa01 / mpv-scripts

This repository contain scripts I have made for mpv media player...
BSD 2-Clause "Simplified" License
507 stars 35 forks source link

SimpleUndo-2.5.lua:68: attempt to index global 'timer' (a nil value) #4

Closed haarp closed 4 years ago

haarp commented 4 years ago

Hello,

just tried SimpleUndo 2.5 and it worked once. Can't get it working again now. mpv 0.29.1 says:

[SimpleUndo_2_5]
[SimpleUndo_2_5] stack traceback:
[SimpleUndo_2_5]    mp.defaults:459: in function 'call_event_handlers'
[SimpleUndo_2_5]    mp.defaults:496: in function 'dispatch_events'
[SimpleUndo_2_5]    mp.defaults:452: in function <mp.defaults:451>
[SimpleUndo_2_5]    [C]: at 0x55925d44bb00
[SimpleUndo_2_5]    [C]: at 0x55925d44d170
[SimpleUndo_2_5] Lua error: /home/haarp/.config/mpv/scripts/SimpleUndo-2.5.lua:68: attempt to index global 'timer' (a nil value)

Thanks!

Eisa01 commented 4 years ago

Are you using Linux or MAC OS?

haarp commented 4 years ago

Linux

Eisa01 commented 4 years ago

It is a very strange one. Can you try to undo in different video and let me know if the issue is there?

haarp commented 4 years ago

Hmm, I think I can reproduce it. It seems to happen when you open directories in mpv instead of the tracks themselves.

Eisa01 commented 4 years ago

Let me know if you are able to confirm it, I will also explore it when I have the time since I did not know about mpv capability to open directories.

Eisa01 commented 4 years ago

If you are able to reproduce it, can you test this version and let me know if it fixes the issue SimpleUndo-2.5.1.lua.zip

gbstan commented 4 years ago

It probably affects other scripts too.

haarp commented 4 years ago

If you are able to reproduce it, can you test this version and let me know if it fixes the issue SimpleUndo-2.5.1.lua.zip

Yes, this version fixes the issue. Thanks!!

Eisa01 commented 4 years ago

Amazing, also applied same fix to UndoRedo because it was affected with the same bug. Issue closed ^ ^