Eisa01 / mpv-scripts

This repository contain scripts I have made for mpv media player...
BSD 2-Clause "Simplified" License
504 stars 35 forks source link

SimpleBookmark: Option to omit specific filters #66

Closed Eisa01 closed 1 year ago

Eisa01 commented 1 year ago

To allow additional filters customization, there should be a way to omit filters from a filter. E.g.: all-groups. The above configuration is a sample for all filter with groups omitted.

Kayizoku commented 1 year ago

Prevent duplicates if the file already exist in a group, don't remove it's current group placement, only update the new time if necessary.

Eisa01 commented 1 year ago

Do you mean if same_entry_limit is set to 0, you want it to update the bookmark with the new time while keeping the group and keybind?

Kayizoku commented 1 year ago

That's right, I noticed the new changes affected some of those options. So decided to add a note for it

Eisa01 commented 1 year ago

Filters are now stackable and omittable https://github.com/Eisa01/mpv-scripts/commit/2b2b456825d64688341c4e7bd8343b8c22b4be21. This makes filters way more diverse. So you can do something like all%-%keybinds%-%groups or you can do keybinds%+%groups

Let me know if this solves this issue for you as well, also you can open other issues for things you noticed.

Kayizoku commented 1 year ago

It's working as it should and I noticed nothing alarming so far. I am able to stack and omit filters as I want. The only little thing I noticed is that even by putting same-entry to 0 I am still unable to make it so it won't update the group-items if I by mistake bookmark a file that's already bookmarked into a group.

Eisa01 commented 1 year ago

Yeah, this update didn't include a change for updating a bookmarked item. The behavior just replaces the current item with a fully new one. I'll see about updating instead of just overwriting

Eisa01 commented 1 year ago

Also, regarding removing highlights; you can press Ctrl+d or Ctrl+a twice to remove all highlights

Eisa01 commented 1 year ago

@Kayizoku

Kayizoku commented 1 year ago

Also, regarding removing highlights; you can press Ctrl+d or Ctrl+a twice to remove all highlights

NIce, thank you. I didn't know that, I found another way by just pressing arrow key to deselect it but this is much better.