Eisa01 / mpv-scripts

This repository contain scripts I have made for mpv media player...
BSD 2-Clause "Simplified" License
504 stars 35 forks source link

SimpleBookmark: Update Entry on Save Instead of Overwriting #67

Closed Eisa01 closed 1 year ago

Eisa01 commented 1 year ago

When saving new bookmark entry for an existing item, it should update the entry with existing slot, and groups. Perhaps this should be a configurable option so user could decide that each new entry should be counted as new, or to update existing entry.

(This is still an idea because the configuration file is already big enough)..

Eisa01 commented 1 year ago

Closed for now as it does not seem that important, especially since this is only the case when overwriting entries. Could re-open in the future if saw that there is a need.

Eisa01 commented 1 year ago

Hi @Kayizoku, is this still needed?

Kayizoku commented 1 year ago

Hi @Kayizoku, is this still needed?

I would appreciate this feature, but it's no issue if its not implemented :)

Eisa01 commented 1 year ago

I will work on it, it will be necessary I guess. Especially after migrating changes to other scripts.

Kayizoku commented 1 year ago

I will work on it, it will be necessary I guess. Especially after migrating changes to other scripts.

Thanks, I will be looking forward to it

Eisa01 commented 1 year ago

@Kayizoku should be done now

Kayizoku commented 1 year ago

@Kayizoku should be done now

My apologies, been a bit busy. But I can confirm its working. Thank you :)