search

EisernSchild / t80

Configurable cpu core that supports Z80, 8080 and gameboy instruction sets.
https://github.com/MiSTer-devel/Main_MiSTer/wiki
11 stars 0 forks source link

compilation error in T80.vhd #2

Closed nealcrook closed 3 years ago

nealcrook commented 3 years ago

Hi, I found your repository after (re)discovering a bug in the INI instruction in the opencores version of the T80 core.

Thank you for your work in maintaining this updated version, and thank you for sharing it on github.

When I try to run an RTL simulation using ModelSim I found a compilation error due to a width mismatch. The problem is with the x"7" which is considered to be 4-bits wide. Here is my (trivial) fix:

<                                               ioq := (ioq and x"7") xor ('0'&BusA);
---
>                                               ioq := (ioq and "000000111") xor ('0'&BusA);

regards, Neal.

jotego commented 3 years ago

This is a warning I've found over and over in simulation. This fix is good.

EisernSchild commented 3 years ago

Thank you, guys ! Did commit that.

Am So., 11. Apr. 2021 um 14:45 Uhr schrieb Jose Tejada < @.***>:

This is a warning I've found over and over in simulation. This fix is good.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/EisernSchild/t80/issues/2#issuecomment-817302037, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADVNRDNUPQCQ4Z4ZZONTRTTIGKVXANCNFSM42XMK6TQ .

nealcrook commented 3 years ago

Cool. Thanks.