/leave should require confirmation when participating in a game

Eisfunke / Secret-Hitler-Telegram

A Telegram Bot that allows groups of users to play Secret Hitler

Other

8 stars 3 forks source link

/leave should require confirmation when participating in a game #90

Open FRQDO opened 4 years ago

FRQDO commented 4 years ago

Players can destroy a running game by accidentally tapping the /leave command suggestion instead of /logs.

Leaving a game without having to confirm should only be possible if

Leaving player is a spectator
Leaving player is dead
Game is in state ACCEPT_PLAYERS
Game is in state GAME_OVER

DerMolly commented 4 years ago

What should the syntax be like? Like the /restart confirm Command or should the bot message the person privately and display the question with options like policy picks?

FRQDO commented 4 years ago

Commands that require a conscious choice and are not used as frequently as, for instance, /enact F (e.g. really restarting the bot even though it cancels running games) should always require users to type them out, I think. Otherwise, we merely add a second layer of “oops I accidentally touched the wrong thing” protection.