Eittipat / pyrtmp

PyRTMP: Pure Python RTMP server
MIT License
90 stars 20 forks source link

Tests don't complete with 3.12 #12

Closed daveisfera closed 10 months ago

daveisfera commented 10 months ago

It appears that this change in the behavior of 3.12 is causing problems. My understanding of asyncio is limited, but it appears that the reader and/or writer need to be closed so wait_for_closed will complete and that's causing the tests to timeout

Eittipat commented 10 months ago

Thank you, I've never been tested in python 12 before

I see you have a patch https://github.com/daveisfera/pyrtmp/commit/3ccf5ef8ee9e10a12574c76f9e111d0120497649 Can you apply this fixes in pull request?

daveisfera commented 10 months ago

I was able to figure out the fix and added it to #11