search

Eiyeron / lsdpatch

LSDj ROM Patcher - Redux
http://www.littlesounddj.com
MIT License
11 stars 1 forks source link

Implement advanced sample import #34

Open urbster1 opened 5 years ago

urbster1 commented 5 years ago

The dither setting (even though it's really bad and no one should use it) could work such that LSDPatcher keeps samples in memory and allows adjusting the dither for each sample up until the kit is actually written into the ROM. When you click on each sample it would be great if the dither slider would remember the setting for each one as long as LSDPatcher is still running.... hopefully this makes some sense

urbster1 commented 5 years ago

Also, dither setting should only be for new samples added from .wav files, not for samples already in the ROM

Eiyeron commented 5 years ago

Relating to #35 too, I'd see an "advanced import" button where there an intermediate window would pop up to open settings such as pre-processing amplitude and post-process dithering.

It'd not break the old flow of drag'n'dropping samples to the window nor the simple option, but it'd allow for a bit more control for people wanting HDR simulation in their samples :p

urbster1 commented 5 years ago

Changed this. It might also be nice to do something like "import at 2x" and automatically double the sample rate, if the sample is intended to be played at 0.5x. Also the 0.5x preview option would be cool

Eiyeron commented 5 years ago

Oooh, clever. I wonder what I should do for the interpolation. Skipping odd/even samples? mean?

urbster1 commented 5 years ago

My suggestion would be skip the odd ones, I wonder if mean would filter out too much, but it might be interesting to try both

urbster1 commented 5 years ago

Would be really cool also to trim start/end of sample since it would help save space - meaning manual adjustment of sample start and end points, and truncating sample accordingly