Bug: Command-line font patching does not replace entire font

Eiyeron / lsdpatch

LSDj ROM Patcher - Redux

http://www.littlesounddj.com

MIT License

11 stars 1 forks source link

Bug: Command-line font patching does not replace entire font #48

Closed urbster1 closed 4 years ago

urbster1 commented 4 years ago

See example screenshot java -jar lsdpatch-redux-1.4.3.jar png2romfnt gb\lsdj815fmdumb.gb lsdfonts\png\boom.png 1 boom The new font does not entirely replace the old font. However, using the GUI works as expected.

Eiyeron commented 4 years ago

Ok, sorry for the inconvenience, I'll have a look.

Eiyeron commented 4 years ago

Ok, I see the issue and potentially a new feature: LSDJ stores fonts in three variant:

colored normally
inverted colors
shaded colors

This exactly makes us three copies of the same font. I forgot to call the function to regenerate the other variants on the command line function.

But also this opens up to a neat idea: why not leaving the ability for the user to tweak the three font variants individually?