fsSelection bold bit set on non-Bold styles

[davelab6]

Sadly the latest release won't be possible to push to GF due to these errors:

ekmukta/EkMukta-ExtraBold.ttf:         fsSelection bold should be 0, is 1
muktavaani/MuktaVaani-SemiBold.ttf:    fsSelection bold should be 0, is 1
muktamahee/MuktaMahee-ExtraBold.ttf:   fsSelection bold should be 0, is 1
ekmukta/EkMukta-SemiBold.ttf:          fsSelection bold should be 0, is 1
muktamalar/MuktaMalar-ExtraBold.ttf:   fsSelection bold should be 0, is 1
mukta/Mukta-ExtraBold.ttf:             fsSelection bold should be 0, is 1
muktamalar/MuktaMalar-SemiBold.ttf:    fsSelection bold should be 0, is 1
muktavaani/MuktaVaani-ExtraBold.ttf:   fsSelection bold should be 0, is 1
mukta/Mukta-SemiBold.ttf:              fsSelection bold should be 0, is 1
muktamahee/MuktaMahee-SemiBold.ttf:    fsSelection bold should be 0, is 1

cc @m4rc1e @felipesanches

[felipesanches]

I've run fontbakery on the last 2 versions of this font on the google/fonts repo and it does report correctly that before today's update (https://github.com/google/fonts/commit/1091d447b265fa24c141cca7be11b5dba31bf7e8) it was good:

INFO     INFO: Style is 'SemiBold'  
INFO     INFO: FSSEL_BOLD bit is 'False'  
INFO     OK: OS/2 fsSelection BOLD bit is properly set. 

And today (after the update) it is bad:

INFO     INFO: Style is 'SemiBold'  
INFO     INFO: FSSEL_BOLD bit is 'True'  
ERROR    OS/2 fsSelection BOLD bit should be reset. 

[m4rc1e]

@davelab6 @felipesanches

This is my fault. in FB's script nametablefromfilename.py, https://github.com/googlefonts/fontbakery/blob/master/bin/fontbakery-nametable-from-filename.py#L157-L171.

[felipesanches]

Yeah. You can change that bold conditional to: if style in ["Bold", "BoldItalic"] just like here: https://github.com/googlefonts/fontbakery/blob/8ea30591740246b0625ef7b947c306e9ad2537a1/Lib/fontbakery/checks.py#L3507-L3511

[felipesanches]

Actually... I'll open an issue and fix it for you.

[m4rc1e]

@felipesanches thank you!

[girish-dalvi]

This seems like an issue in fontbakery-nametable-from-filename.py, the bit is set properly in the source TTX files.

[felipesanches]

@girish-dalvi I've just fixed it (on the closed FB pull request above) and Marc will probably update the fonts soon.

[girish-dalvi]

@felipesanches Thank you for the quick fix! @davelab6 @m4rc1e Since the bits are set properly in the source files, I'll close this issue.

[m4rc1e]

@girish-dalvi thanks and apologies for this.

[davelab6]

Yes good call Girish, thanks!!

On May 23, 2017 3:20 PM, "Marc Foley" notifications@github.com wrote:

@girish-dalvi https://github.com/girish-dalvi thanks and apologies for this.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/EkType/Mukta/issues/26#issuecomment-303504294, or mute the thread https://github.com/notifications/unsubscribe-auth/AAP9yzMUWOzbPYeoyk0UP_RBSxxsyod5ks5r8zF7gaJpZM4Nj7YK .