search

Ekeany / Boruta-Shap

A Tree based feature selection tool which combines both the Boruta feature selection algorithm with shapley values.
MIT License
559 stars 86 forks source link

in response to [BUG] BorutaSHAP.py load Boston Import Error #111 #114

Closed IanWord closed 1 year ago

IanWord commented 1 year ago

Scikit-learn >1.2 do not support the use of the Boston dataset from sklearn.datasets. This problem was raised back in december: https://github.com/Ekeany/Boruta-Shap/issues/111 and while one could make workaround importing Boston dataset from other sources, I am not an official maintainer. I merely suggest to replace sklearn.datasets toy dataset: load_boston() with load_diabetes().

What does this PR do?

This PR replaces the use of the load_boston() dataset in BorutaShap with load_diabetes() to avoid compatibility issues with scikit-learn >1.2.

References

-Issue raised in December 2022: https://github.com/Ekeany/Boruta-Shap/issues/111 -Documentation for load_diabetes(): https://scikit-learn.org/stable/modules/generated/sklearn.datasets.load_diabetes.html#sklearn.datasets.load_diabetes

Testing performed

I have tested the loading functionality, replacing load_diabetes() with load_boston(), on my local machine and the code runs without errors.

Known issues

MauritsDescamps commented 1 year ago

@Ekeany When will this be merged?

IanWord commented 1 year ago

@MauritsDescamps seems abandoned. A shame, its a great tool.

bchaplin1 commented 1 year ago

@MauritsDescamps seems abandoned. A shame, its a great tool.

agree. hope to see this implemented soon