Open matheusvasconcellosb opened 9 months ago
The class works well if used in isolation but not that much inside a pipeline.
We could clean up fit method and move params to class definition to be easier to perform parameter tunning using scikit-learn compatible stuff..
Why should this enhancement be added to the repository? --> scikit-learn better compatibility
move paramters to class definition
Concrete tasks to be completed, in the order they need to be done in. Include links to specific lines of code where the task should happen at.
Current Situation
The class works well if used in isolation but not that much inside a pipeline.
Enhancement
We could clean up fit method and move params to class definition to be easier to perform parameter tunning using scikit-learn compatible stuff..
Reasoning
Why should this enhancement be added to the repository? --> scikit-learn better compatibility
Implementation
move paramters to class definition
Tasks
Concrete tasks to be completed, in the order they need to be done in. Include links to specific lines of code where the task should happen at.